search

spacetelescope / romancal

Python library to process science observations from the Nancy Grace Roman Space Telescope
https://roman-pipeline.readthedocs.io/en/latest/
Other
32 stars 28 forks source link

Outlier detection issues with weight option #1428

Open braingram opened 1 month ago

braingram commented 1 month ago

Outlier detection without resampling uses hard-coded "ivm" weight https://github.com/spacetelescope/romancal/blob/b652ef8ba98d0c6b4c135e66ee7eee21eb885308/romancal/outlier_detection/outlier_detection.py#L96

braingram commented 1 month ago

And related, ResampleData understands wht_type: https://github.com/spacetelescope/romancal/blob/b652ef8ba98d0c6b4c135e66ee7eee21eb885308/romancal/resample/resample.py#L52 whereas outlier detection passes in weight_type: https://github.com/spacetelescope/romancal/blob/b652ef8ba98d0c6b4c135e66ee7eee21eb885308/romancal/outlier_detection/outlier_detection_step.py#L108 so "weight_type" is ignored.

braingram commented 1 month ago

@stscijgbot-rstdms