spacetelescope / romanisim

Nancy Grace Roman Space Telescope WFI Data Simulator
https://romanisim.readthedocs.io
Other
15 stars 13 forks source link

Use numerical inverse to improve WCS accuracy #110

Closed schlafly closed 5 months ago

schlafly commented 5 months ago

There is an issue with the distortion reference files in CRDS such that wcs.world_to_pixel(wcs.pixel_to_world(...)) only inverts at the 0.05 pix level. That makes it impossible to do astrometry better than ~0.05 pix. This replaces wcs.world_to_pixel with wcs.numerical_inverse to avoid this issue. This is slightly slower, so we will restore the original approach when the reference file issue is resolved.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.21%. Comparing base (725b7cb) to head (dedd5e1). Report is 9 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #110 +/- ## ========================================== - Coverage 92.44% 92.21% -0.23% ========================================== Files 16 16 Lines 1509 1593 +84 ========================================== + Hits 1395 1469 +74 - Misses 114 124 +10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.