search

spacetelescope / romanisim

Nancy Grace Roman Space Telescope WFI Data Simulator
https://romanisim.readthedocs.io
Other
15 stars 13 forks source link

Document feature for generating images with all SCAs #129

Closed bmorris3 closed 4 months ago

bmorris3 commented 4 months ago

On main, users can generate images for all SCAs using romanisim-make-image ... --sca -1 ..., in a case that gets caught here: https://github.com/spacetelescope/romanisim/blob/e0e6a979db8b43cbdb22e8082ae14e9ed2f8cd4d/scripts/romanisim-make-image#L27-L37

This feature isn't written about in the docs or in the argument's help notes, so I've added a note to both.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.44%. Comparing base (0a1aac5) to head (1bf6bd7). Report is 62 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #129 +/- ## ========================================== - Coverage 90.78% 87.44% -3.34% ========================================== Files 17 17 Lines 1671 1689 +18 ========================================== - Hits 1517 1477 -40 - Misses 154 212 +58 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

schlafly commented 4 months ago

Thank you!