search

spacetelescope / romanisim

Nancy Grace Roman Space Telescope WFI Data Simulator
https://romanisim.readthedocs.io
Other
15 stars 13 forks source link

Add frame zero effects. #130

Closed schlafly closed 4 months ago

schlafly commented 4 months ago

Adds correlated noise across all reads associated with noise in the reference read (frame zero), which is subtracted from all subsequent reads.

A new parameter, pedestal_extra_noise, is added, with a default value of 4 DN. Noise is added to all resultants in each pixel with amplitude equal to the quadrature sum of the pixel's read noise and the extra pedestal noise.

This noise is degenerate with the pedestal and so doesn't meaningfully affect final ramp measurements at present.

We use a separate RNG so that pedestal noise can be turned on and off without affecting the rest of the random numbers in the simulation.

I also added corresponding tests.

schlafly commented 4 months ago

@PaulHuwe , want to take a look?

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.94%. Comparing base (0a1aac5) to head (fef50a8). Report is 62 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #130 +/- ## ========================================== + Coverage 90.78% 90.94% +0.16% ========================================== Files 17 17 Lines 1671 1701 +30 ========================================== + Hits 1517 1547 +30 Misses 154 154 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.