search

spacetelescope / romanisim

Nancy Grace Roman Space Telescope WFI Data Simulator
https://romanisim.readthedocs.io
Other
15 stars 13 forks source link

[SCSB-170] pin Python<3.13 #139

Closed zacharyburnett closed 1 month ago

zacharyburnett commented 1 month ago

Resolves SCSB-170

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.95%. Comparing base (d4af8fd) to head (e50b818). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #139 +/- ## ======================================= Coverage 89.95% 89.95% ======================================= Files 17 17 Lines 1792 1792 ======================================= Hits 1612 1612 Misses 180 180 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

schlafly commented 1 month ago

I'm merging this since it resolves the build failures, but I'm confused about the content of the PR, which looks more like "build wheels for python != 3.13" and the title of the PR (pin python <3.13).

zacharyburnett commented 1 month ago

I'm merging this since it resolves the build failures, but I'm confused about the content of the PR, which looks more like "build wheels for python != 3.13" and the title of the PR (pin python <3.13).

Oh sorry! I was working with a very similar PR in another tab and must have gotten them confused.

schlafly commented 1 month ago

Sounds good, thanks. Do you understand the issue? Somehow I expect python 3.13 problems to manifest as syntax errors or unit test errors and not only in compiling the binaries, but maybe if cython isn't happy with 3.13 then it might only appear when building wheels.

zacharyburnett commented 1 month ago

Sounds good, thanks. Do you understand the issue? Somehow I expect python 3.13 problems to manifest as syntax errors or unit test errors and not only in compiling the binaries, but maybe if cython isn't happy with 3.13 then it might only appear when building wheels.

I don't understand the issue, but from further experimentation with cibuildwheel yesterday I think we should revert this change and instead pin Python in pyproject.toml until we can figure out why it's failing; that will be much more maintainable and also prevent users from trying to install on 3.13 and getting installation errors.

I'll make another PR