spacetelescope / science-platform-images

Other
4 stars 7 forks source link

JUSI-1634, JUSI-1637 #39

Closed cganley1 closed 5 months ago

cganley1 commented 5 months ago

Included xarray as additional roman-cal package, Added post-start-hook to install jdaviz. Upon further testing, jdaviz worked with test notebooks if it was installed as the last package in the kernel, hence the use of the post-start-hook. This will create issues capturing frozen requirements as dependencies are updated over time.

jaytmiller commented 5 months ago

I would second what @msanchezst just said, but what really concerns me as that dynamically installing the code undercuts one of the premises of the hub images... that they are stable. Would moving the solo pip install to the end of Dockerfile.custom help? That undercuts the frozen requirements some since they come from pip-tools which would not see this later install, but I think it may still work using both floating and frozen requirements since it would occur after all the env-xxx stuff. It would not be as stable as a pure env-xxx build, but once built the image itself would be stable.

cganley1 commented 5 months ago

New commit moves installation to dockerfile instead of post-start-hook.

cganley1 commented 5 months ago

New commit creates jdaviz kernel and updates environment variables.