spacetelescope / spherical_geometry

A Python package for handling spherical polygons that represent arbitrary regions of the sky
http://spherical-geometry.readthedocs.io/
61 stars 31 forks source link

Bump minversions, update CI #240

Closed pllim closed 11 months ago

pllim commented 11 months ago
codecov[bot] commented 11 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Files Coverage Δ
spherical_geometry/__init__.py 100.00% <100.00%> (+40.00%) :arrow_up:
spherical_geometry/graph.py 93.15% <100.00%> (+0.26%) :arrow_up:
spherical_geometry/great_circle_arc.py 41.22% <ø> (-0.89%) :arrow_down:
spherical_geometry/polygon.py 82.42% <ø> (-0.05%) :arrow_down:
spherical_geometry/vector.py 81.66% <ø> (-0.31%) :arrow_down:
setup.py 0.00% <0.00%> (ø)

:loudspeaker: Thoughts on this report? Let us know!.

pllim commented 11 months ago

Either this package somehow does not use any of the 666 deprecated/removed things in numpy 2.0 or your coverage sux. 😆

pllim commented 11 months ago

I really don't think there is anything controversial here. I am just removing a bunch of dead code. CI is still green somehow. I was expecting some tech debt for Python 3.12 or numpy 2.0 but I do not see them as far as the code is tested.

Just gonna merge so I can build on top of this.