Closed pllim closed 11 months ago
Attention: 21 lines
in your changes are missing coverage. Please review.
Files | Coverage Δ | |
---|---|---|
spherical_geometry/__init__.py | 100.00% <100.00%> (ø) |
|
spherical_geometry/graph.py | 93.19% <100.00%> (+0.03%) |
:arrow_up: |
spherical_geometry/polygon.py | 82.37% <100.00%> (-0.05%) |
:arrow_down: |
spherical_geometry/vector.py | 84.48% <ø> (+2.81%) |
:arrow_up: |
spherical_geometry/great_circle_arc.py | 39.53% <12.50%> (-1.69%) |
:arrow_down: |
... and 1 file with indirect coverage changes
:loudspeaker: Thoughts on this report? Let us know!.
Despite the scary diff, users won't actually see anything different. All they will get are new wheels after next release. So no need for change log.
This is in a good state now, so I am going to YOLO merge it. If you run into problems, will be happy to come back to help. Enjoy your wheels!
Please use SQUASH AND MERGE button!
helpers.py
After merge:
NUMPY_EXPERIMENTAL_DTYPE_API
) and the xfail. Maybe tox is preventing the CI to see the.so
file but I don't know how to fix.synphot
works just fine with tox (though not OpenAstronomy) andastropy
also works fine (with OpenAstronomy).~ (fixed!)