search

spacetelescope / spherical_geometry

A Python package for handling spherical polygons that represent arbitrary regions of the sky
http://spherical-geometry.readthedocs.io/
62 stars 31 forks source link

manylinux_aarch64: Takes too long to build #247

Open pllim opened 12 months ago

pllim commented 12 months ago

Couldn't pull it off in https://github.com/spacetelescope/spherical_geometry/pull/243 . Took way longer than other archs and I didn't have the patience or interest to find out why.

No one uses this package in that architecture and somehow need the wheel from PyPI, right?

falkben commented 12 months ago

~It would be very convenient to be able to install on developer macs instead of needing to build from source each time.~

Edit: sorry, misread or didn't see the title. I now see you only mean linux arm64 (aarch64). I can see the macosx arm64 whl files in the latest artifacts.

We would not be using this any time soon -- the only thing I can think of is that it would enable us to run applications on arm CPU's in the cloud (e.g. graviton) which can be slightly less costly. Not urgent.

pllim commented 12 months ago

Yes, OSX ARM should have a wheel when the new release is out.

AstroPatty commented 8 months ago

I did run into a potential use case of this that might be relevant. I have a project that executes tests in a container. I'm on an M Series Mac, which by default built the container as an arm64 linux container. The build failed because spherical-geometry doesn't have a wheel for that combo.

I can force it to build as x86, so it's not a big issue. But still a +1 for fixing this eventually. I can maybe try to put some time into this sometime.

pllim commented 8 months ago

@PatrickRWells , I am confused. This issue is about manylinux_aarch64, not M-series Mac. There should be wheels for OSX ARM64 already. See https://pypi.org/project/spherical-geometry/#files

Are you using a very old Python? You need Python 3.9 or later.

falkben commented 8 months ago

@pllim They are running in linux (docker) so this does apply.

pllim commented 8 months ago

In that case, don't use a manylinux_aarch64 container if possible. I have no solution to this problem and I am not a maintainer of this package, so I don't have any ETA for this fix.

pllim commented 4 months ago

Might want to revisit this again when numpy 2.x stuff is settled. Please ping us again if we forget. Thanks!