search

spacetelescope / spherical_geometry

A Python package for handling spherical polygons that represent arbitrary regions of the sky
http://spherical-geometry.readthedocs.io/
61 stars 31 forks source link

TST: OSX ARM64 throws RuntimeWarning now #263

Closed pllim closed 4 months ago

pllim commented 4 months ago

I don't know why though.

xref #262

pllim commented 4 months ago

Huh, CI was disabled due to inactivity. I have to close/reopen to trigger it. The OSX ARM64 wheel job did pass though, but this is more like a bandaid. I think we need to understand why it is throwing RuntimeWarning and not ValueError as stated here:

https://github.com/spacetelescope/spherical_geometry/blob/5de7fc79d8e3cb4f1c0a9338acf06b350d17b15b/src/math_util.c#L250-L255

Thanks to @jhunkeler for digging out the code.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.28%. Comparing base (5de7fc7) to head (d311a3d).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #263 +/- ## ======================================= Coverage 81.28% 81.28% ======================================= Files 5 5 Lines 1010 1010 ======================================= Hits 821 821 Misses 189 189 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pllim commented 4 months ago

devdeps failure is unrelated (#261)

mcara commented 4 months ago

The problems appear to be due to import failure of math_util even though math_util...so is built. very strange. If this import fails, the code fallback to the Python code. Probably that code is buggy too and hence the errors. So, two things need to be fixed: Python code and import of the compiled C module build with numpy 2.0.

pllim commented 4 months ago

OK then I'll leave it to the experts. Thanks!