spacetelescope / spherical_geometry

A Python package for handling spherical polygons that represent arbitrary regions of the sky
http://spherical-geometry.readthedocs.io/
61 stars 31 forks source link

Make math_util compatible with numpy 2.0 #270

Closed mcara closed 3 months ago

mcara commented 3 months ago

This will make C code in math_util.c compatible and compile with numpy 2.0. However, in order for dev tests to succeed, the build must be forced to use numpy 2.0 in tox.ini (currently that line is commented out).

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.28%. Comparing base (5de7fc7) to head (1e3d5d7). Report is 3 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #270 +/- ## ======================================= Coverage 81.28% 81.28% ======================================= Files 5 5 Lines 1010 1010 ======================================= Hits 821 821 Misses 189 189 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mcara commented 3 months ago

@jhunkeler unofficially approved this PR but the is afraid to publicly support it.