spacetelescope / stcal

https://stcal.readthedocs.io/en/latest/
Other
10 stars 32 forks source link

[benchmark] use `mamba` in environment construction #185

Closed zacharyburnett closed 1 year ago

zacharyburnett commented 1 year ago

the conda environment construction in asv currently fails on tangra3 due to the current setup; however, switching the environment_type to mamba does work.

mamba is a rewrite of conda that is both significantly faster in the environment resolution step and has parity of commands with conda. Since the regular benchmarking on tangra3 creates an environment, it makes sense to use mamba going forward.

asv currently supports environment_type = mamba in its main branch code, and AFAIK this will be included in the next release. For now, the tangra3 benchmarks use pip install git+https://github.com/airspeed-velocity/asv.git

Checklist

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (2256c48) 75.36% compared to head (6b4ebb8) 75.36%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #185 +/- ## ======================================= Coverage 75.36% 75.36% ======================================= Files 33 33 Lines 6039 6039 ======================================= Hits 4551 4551 Misses 1488 1488 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kmacdonald-stsci commented 1 year ago

What is the advantage of Mamba over Conda? That's not explained in this PR.

zacharyburnett commented 1 year ago

What is the advantage of Mamba over Conda? That's not explained in this PR.

Whoops, sorry! updated the description

nden commented 1 year ago

Now that benchmarks are in bench, should this be closed?