Closed mairanteodoro closed 1 year ago
Patch coverage: 97.82%
and project coverage change: +0.15%
:tada:
Comparison is base (
8acd94c
) 74.96% compared to head (4644bdc
) 75.12%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Resolves RCAL-632
This PR addresses adding new methods required by the resampling step for RomanCal and its corresponding unit tests.
Notes
For JWST, the
update_s_region_imaging
is callingwcs.footprint
withcenter=True
, which means the footprint coordinates will be those of the center of the pixels. However, since we're using a bounding box to calculate the footprint, it would make sense to use the vertices of the pixels instead of the center, which is the default behavior of thewcs.footprint
method. Therefore, we added the option to pass thecenter
parameter toupdate_s_region_imaging
in order to make the unit tests pass the correct way of usingwcs.footprint
.This PR is blocking the PR for the resample step.
Checklist
CHANGES.rst
(either inBug Fixes
orChanges to API
)