search

spacetelescope / stcal

https://stcal.readthedocs.io/en/latest/
Other
10 stars 32 forks source link

Install dev wheels properly #222

Closed pllim closed 11 months ago

pllim commented 1 year ago

You can simplify devdeps calls and you can also install astropy dev from wheel.

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (4d44cd8) 84.31% compared to head (99afc5f) 84.31%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #222 +/- ## ======================================= Coverage 84.31% 84.31% ======================================= Files 35 35 Lines 6452 6452 ======================================= Hits 5440 5440 Misses 1012 1012 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pllim commented 11 months ago

I added a commit due to:

pllim commented 11 months ago

But do you actually use devdeps? I don't see it in the jobs here.

zacharyburnett commented 11 months ago

But do you actually use devdeps? I don't see it in the jobs here.

213 adds devdeps as an optional workflow when adding the run devdeps tests label, but it isn't merged yet

pllim commented 11 months ago

OK, then maybe you can merge this first and see if this setup really works on your other PR. 🤞

Or feel free to cherry pick the commits over and close this without merge.