RCAL-702: Fix memory use issue for Cas22 jump detection

spacetelescope / stcal

https://stcal.readthedocs.io/en/latest/

Other

10 stars 32 forks source link

RCAL-702: Fix memory use issue for Cas22 jump detection #226

Closed WilliamJamieson closed 12 months ago

WilliamJamieson commented 1 year ago

Resolves RCAL-702

This PR resolves a massive memory spike as part of the solution to RCAL-702

Checklist

[ ] added entry in CHANGES.rst (either in Bug Fixes or Changes to API)
[ ] updated relevant tests
[ ] updated relevant documentation
[ ] updated relevant milestone(s)
[ ] added relevant label(s)

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Files	Coverage Δ
src/stcal/ramp_fitting/ols_cas22_fit.py	`81.25% <100.00%> (ø)`
tests/test_jump_cas22.py	`100.00% <100.00%> (ø)`

:loudspeaker: Thoughts on this report? Let us know!.

schlafly commented 1 year ago

@stscieisenhamer , mind checking to see if this resolves your issue? Thanks!

schlafly commented 12 months ago

I think I see that with include_diagnostic=False we don't get any information back about where the jumps are and we don't end up updating the DQ array. I think we need that. Ideally that could happen in place on the DQ array, so no additional memory were needed; I'm not sure how convenient that ends up being here.