spacetelescope / stcal

https://stcal.readthedocs.io/en/latest/
Other
10 stars 32 forks source link

fix poisson calculation #254

Closed mwregan2 closed 6 months ago

mwregan2 commented 6 months ago

Resolves JP-3463

This PR addresses a bug in the original PR #243. The addition of the dark current noise in the original PR was not the correct version. This PR fixes that and we now get the correct Poisson variance.

Checklist

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.95%. Comparing base (af5aefb) to head (4d429d0). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #254 +/- ## ========================================== - Coverage 85.18% 84.95% -0.23% ========================================== Files 35 35 Lines 6797 6846 +49 ========================================== + Hits 5790 5816 +26 - Misses 1007 1030 +23 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.