spacetelescope / stcal

https://stcal.readthedocs.io/en/latest/
Other
10 stars 32 forks source link

JP-3623: Catch Runtime warnings in jump step #258

Closed drlaw1558 closed 5 months ago

drlaw1558 commented 5 months ago

Resolves JP-3623 by catching a few runtime warnings in the jump step that were no longer caught after recent updates.

Closes spacetelescope/jwst#8483

Checklist

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.00%. Comparing base (af5aefb) to head (e260c12). Report is 6 commits behind head on main.

:exclamation: Current head e260c12 differs from pull request most recent head dfe2eba

Please upload reports for the commit dfe2eba to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #258 +/- ## ========================================== - Coverage 85.18% 85.00% -0.19% ========================================== Files 35 35 Lines 6797 6867 +70 ========================================== + Hits 5790 5837 +47 - Misses 1007 1030 +23 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

drlaw1558 commented 5 months ago

No change log. Also, is it possible to add a CI test to ensure tests are being reported (or not) as expected?

Not sure how to add a test for error messages from these specific locations, but have added a change log entry.

hbushouse commented 5 months ago

Closing and reopening to trigger CI tests.