spacetelescope / stcal

https://stcal.readthedocs.io/en/latest/
Other
10 stars 32 forks source link

Move outlier detection utility functions from jwst to stcal #270

Closed braingram closed 3 months ago

braingram commented 3 months ago

This PR moves a number of utility functions related to outlier detection from jwst to stcal.

This PR is required for https://github.com/spacetelescope/jwst/pull/8613

As this PR adds a few new dependencies (and these are added to the devdeps) the run devdeps tests label was added. It's expected that the jwst devdeps will fail as they are failing on main: https://github.com/spacetelescope/stcal/actions/runs/9836681142/job/27152917937

Checklist

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 96.73913% with 6 lines in your changes missing coverage. Please review.

Project coverage is 84.32%. Comparing base (58018d4) to head (2112773). Report is 190 commits behind head on main.

Files with missing lines Patch % Lines
src/stcal/outlier_detection/utils.py 96.55% 3 Missing :warning:
tests/outlier_detection/test_utils.py 96.90% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #270 +/- ## ========================================== + Coverage 84.01% 84.32% +0.31% ========================================== Files 39 41 +2 Lines 7345 7529 +184 ========================================== + Hits 6171 6349 +178 - Misses 1174 1180 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

braingram commented 3 months ago

Closing and opening to re-trigger CI since the run devdeps tests label didn't seem to take.

emolter commented 3 months ago

looks like mypy needs an override in pyproject.toml for drizzle