spacetelescope / stcal

https://stcal.readthedocs.io/en/latest/
Other
10 stars 32 forks source link

Add common resample code to stcal #279

Open mcara opened 2 months ago

mcara commented 2 months ago

This PR add the common resample code used by both JWST and Roman pipelines to stcal. Also, for the first time, this PR adopts the new drizzle API from https://github.com/spacetelescope/drizzle/pull/134 for the resample code used in the pipelines.

This work is related to https://jira.stsci.edu/browse/AL-835

At this moment this is a very rough draft for illustration purpose. It should run with default arguments (except input_models and output file name can be specified; everything else is not guaranteed to work). There are no unit/regression tests and documentation may not match the code.

Checklist

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 92.53996% with 42 lines in your changes missing coverage. Please review.

Project coverage is 33.42%. Comparing base (60bd3b8) to head (55294b0). Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/stcal/resample/resample.py 92.48% 42 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #279 +/- ## =========================================== - Coverage 86.21% 33.42% -52.80% =========================================== Files 47 39 -8 Lines 8812 8818 +6 =========================================== - Hits 7597 2947 -4650 - Misses 1215 5871 +4656 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

braingram commented 2 months ago

Would you rebase this and add a drizzle dependency with the branch for https://github.com/spacetelescope/drizzle/pull/134 so we can see the CI run?