spacetelescope / stcal

https://stcal.readthedocs.io/en/latest/
Other
10 stars 32 forks source link

Add optional parameter to alignment methods and handle catalog web service connection issues. #286

Closed mairanteodoro closed 1 month ago

mairanteodoro commented 1 month ago

Resolves RCAL-908

This PR add an optional parameter -- clip_accum -- to the alignment methods in stcal.tweakreg. This is necessary because JWST and Roman do not use the same value when it comes to that parameter. The default value for that parameter in align_wcs() is False, which is what JWST uses. However, clip_accum=True seems to significantly improve the fitting results for Roman (as compared with clip_accum=False).

This PR also adds the ability to better handle catalog web services connectivity issues.

Checklist

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.65%. Comparing base (d85f859) to head (886ba82). Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
src/stcal/tweakreg/astrometric_utils.py 75.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #286 +/- ## ========================================== + Coverage 84.63% 84.65% +0.02% ========================================== Files 41 41 Lines 7628 7651 +23 ========================================== + Hits 6456 6477 +21 - Misses 1172 1174 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mairanteodoro commented 1 month ago

Why did you add the no_changelog_entry_needed tag?

I did that temporarily -- it's still a draft PR. I am working on the changelog entry now.