Closed mairanteodoro closed 1 month ago
Attention: Patch coverage is 91.66667%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 84.65%. Comparing base (
d85f859
) to head (886ba82
). Report is 13 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
src/stcal/tweakreg/astrometric_utils.py | 75.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Why did you add the no_changelog_entry_needed tag?
I did that temporarily -- it's still a draft PR. I am working on the changelog entry now.
Resolves RCAL-908
This PR add an optional parameter --
clip_accum
-- to the alignment methods instcal.tweakreg
. This is necessary because JWST and Roman do not use the same value when it comes to that parameter. The default value for that parameter inalign_wcs()
is False, which is what JWST uses. However,clip_accum=True
seems to significantly improve the fitting results for Roman (as compared withclip_accum=False
).This PR also adds the ability to better handle catalog web services connectivity issues.
Checklist
[x] for a public change, added a towncrier news fragment in
changes/
:echo "changed something" > changes/<PR#>.<changetype>.rst
changes/<PR#>.apichange.rst
: change to public APIchanges/<PR#>.bugfix.rst
: fixes an issuechanges/<PR#>.general.rst
: infrastructure or miscellaneous change