Closed emolter closed 1 month ago
Attention: Patch coverage is 99.23664%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 85.19%. Comparing base (
8988d2c
) to head (c2d10b7
). Report is 2 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
src/stcal/outlier_detection/median.py | 98.60% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
jwst regtests started here edit: no failures
@braingram I think I incorporated all your comments with the most recent push. Thanks for the docstring updates, I think they improved things a lot, and I agree with your idea to make the OnDiskMedian and DiskAppendableArray private
Would you add
median.py
to the docs? It will likely be easier if the submodule has an__all__
(I added a comment about this) which will also help to define the "public" API.
Was the addition of this new API to the docs not pushed?
Would you add
median.py
to the docs? It will likely be easier if the submodule has an__all__
(I added a comment about this) which will also help to define the "public" API.Was the addition of this new API to the docs not pushed?
I didn't even see the comment, my fault. I will look at the docs from this branch and see what changes are needed. I did already add the __all__
Downstream romancal failures are what I'd consider unrelated. It appears the CI is using the pytest configuration from stcal when running those tests (instead of using the one in romancal). The jwst tests haven't finished but I wouldn't be surprised if it does the same thing (and is now turning some unclosed file warnings into errors).
Thanks for updating the docs, they look good to me: https://stcal--292.org.readthedocs.build/en/292/stcal/outlier_detection/index.html
I think https://github.com/spacetelescope/stcal/pull/292#discussion_r1782630616 is the only unresolved comment I made.
Resolves JP-3768
This PR ports the median calculation machinery added by https://github.com/spacetelescope/jwst/pull/8782 into stcal for use by other missions. See https://github.com/spacetelescope/jwst/pull/8840 for the related changes in jwst.
Tasks
docs/
pageno-changelog-entry-needed
)changes/
:echo "changed something" > changes/<PR#>.<changetype>.rst
(see below for change types)"git+https://github.com/<fork>/stcal@<branch>"
)jwst
regression testromancal
regression testnews fragment change types...
- ``changes/