spacetelescope / stcal

https://stcal.readthedocs.io/en/latest/
Other
10 stars 32 forks source link

Enable style checks #293

Closed braingram closed 4 weeks ago

braingram commented 1 month ago

Style checks (via pre-commit) have not been checking any files in this repo as part of the CI. See this recent run on main: https://github.com/spacetelescope/stcal/actions/runs/11017955113/job/30597119856#step:10:63 With all checks showing:

check for added large files..........................(no files to check)Skipped

If I run them locally I see a large number of automatic changes: 36 files changed, 1091 insertions(+), 942 deletions(-) and even after these see 79 ruff errors, many from codespell and 6 from reporeview.

In an effort to check something this PR:

With this PR the checks run: https://github.com/spacetelescope/stcal/actions/runs/11130795981/job/30930929199?pr=293#step:10:49

Tasks

news fragment change types... - ``changes/.apichange.rst``: change to public API - ``changes/.bugfix.rst``: fixes an issue - ``changes/.general.rst``: infrastructure or miscellaneous change
codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.19%. Comparing base (8988d2c) to head (5f94030). Report is 6 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #293 +/- ## ========================================== + Coverage 84.76% 85.19% +0.43% ========================================== Files 44 46 +2 Lines 8542 8804 +262 ========================================== + Hits 7241 7501 +260 - Misses 1301 1303 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.