search

spacetelescope / stcal

https://stcal.readthedocs.io/en/latest/
Other
10 stars 32 forks source link

calc_bias contains a missing import and is unused #296

Open braingram opened 4 weeks ago

braingram commented 4 weeks ago

https://github.com/spacetelescope/stcal/blob/787aa81a6719bb0c72be8972171c7f3f88c8adf0/src/stcal/ramp_fitting/likely_algo_classes.py#L251

contains attempted uses of fit_ramps: https://github.com/spacetelescope/stcal/blob/787aa81a6719bb0c72be8972171c7f3f88c8adf0/src/stcal/ramp_fitting/likely_algo_classes.py#L289 which is undefined.

As we haven't seen any errors it's likely calc_bias is unused.

It's unclear to me if this is a bug (and it should be used) or if the test coverage is incomplete and we may see failures during non-test runs.