spacetelescope / stcal

https://stcal.readthedocs.io/en/latest/
Other
10 stars 32 forks source link

support python 3.13 #300

Open braingram opened 3 weeks ago

braingram commented 3 weeks ago

This PR adds support for python 3.13 and adds 3.13 testing to the CI.

Tasks

news fragment change types... - ``changes/.apichange.rst``: change to public API - ``changes/.bugfix.rst``: fixes an issue - ``changes/.general.rst``: infrastructure or miscellaneous change
codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.35%. Comparing base (60bd3b8) to head (419a208). Report is 6 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #300 +/- ## ========================================== + Coverage 86.21% 86.35% +0.14% ========================================== Files 47 49 +2 Lines 8812 8905 +93 ========================================== + Hits 7597 7690 +93 Misses 1215 1215 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

braingram commented 3 weeks ago

Blocked by https://github.com/spacetelescope/stcal/issues/301

braingram commented 3 weeks ago

Rebased to include https://github.com/spacetelescope/stcal/pull/303 to test it with python 3.13

braingram commented 3 weeks ago

Converted this back to draft. The build with 3.13 failed due to failure to build a wheel for scikit-image: https://github.com/spacetelescope/stcal/actions/runs/11278541799/job/31367250216?pr=300#step:7:997 It looks like they don't have a 3.13 release yet: https://pypi.org/project/scikit-image/#files I don't think was previously failing so I'll try to re-run the job but it probably makes sense to wait until they have a release with 3.13 wheels.

WilliamJamieson commented 1 day ago

Converted this back to draft. The build with 3.13 failed due to failure to build a wheel for scikit-image: spacetelescope/stcal/actions/runs/11278541799/job/31367250216?pr=300#step:7:997 It looks like they don't have a 3.13 release yet: pypi.org/project/scikit-image#files I don't think was previously failing so I'll try to re-run the job but it probably makes sense to wait until they have a release with 3.13 wheels.

scikit-image, added support in scikit-image/scikit-image#7565 and wheels as part of scikit-image/scikit-image#7571, both of which have appeared in version 0.25.0rc1. That pre-release version includes Python 3.13 wheels, so I have temporarily forced the installation of the pre-release when using 3.13. According to https://github.com/scikit-image/scikit-image/issues/7596#issuecomment-2440286571 the release 0.25 will have support for Python 3.13 and seems like it should occur soon.

If we are comfortable using the pre-release for now (I believe it will pull the release once that comes out), I think this PR is ready.