Closed kmacdonald-stsci closed 3 weeks ago
Here is the regression testing for this PR:
https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1778/
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 86.21%. Comparing base (
60bd3b8
) to head (ae6a7c8
). Report is 2 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Closing as a duplicate PR for https://github.com/spacetelescope/stcal/pull/300
Sorry for any confusion. I rebased this into https://github.com/spacetelescope/stcal/pull/300 just to see if it fixed the issue. I think it makes sense to approve and merge this PR then rebase and open #300.
This PR prepares the ramp fitting C-extension for the upgrade to python 3.13. This version of python added an exception to the
PyLong_AsLong
function if thePyObject
passed to it isNoneType
. Now for two attributes ofRampData
that can beNoneType
a check needs to be put in place guard against this exception. The other attributes ofRampData
that are expected to be integer type should never beNoneType
, so should raise an exception if they are.Tasks
docs/
pageno-changelog-entry-needed
)changes/
:echo "changed something" > changes/<PR#>.<changetype>.rst
(see below for change types)"git+https://github.com/<fork>/stcal@<branch>"
)jwst
regression testromancal
regression testnews fragment change types...
- ``changes/