search

spacetelescope / stcal

https://stcal.readthedocs.io/en/latest/
Other
10 stars 32 forks source link

JP-3677: Add maximum_shower_amplitude parameter to jump step #306

Open drlaw1558 opened 2 weeks ago

drlaw1558 commented 2 weeks ago

This PR addresses JP-3677 by adding a maximum_shower_amplitude parameter to the MIRI cosmic ray showers code, and ensuring that any changes in the rate image due to shower flagging are below this amplitude.

See also corresponding jwst PR https://github.com/spacetelescope/jwst/pull/8890

Tasks

news fragment change types... - ``changes/.apichange.rst``: change to public API - ``changes/.bugfix.rst``: fixes an issue - ``changes/.general.rst``: infrastructure or miscellaneous change
codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 77.77778% with 6 lines in your changes missing coverage. Please review.

Project coverage is 86.50%. Comparing base (60bd3b8) to head (3f6f8d3). Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/stcal/jump/jump.py 77.77% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #306 +/- ## ========================================== + Coverage 86.21% 86.50% +0.29% ========================================== Files 47 49 +2 Lines 8812 8868 +56 ========================================== + Hits 7597 7671 +74 + Misses 1215 1197 -18 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

drlaw1558 commented 2 weeks ago

Not sure why I can't request a review, but tagging @kmacdonald-stsci

ddavis-stsci commented 2 weeks ago

The romancal regression tests pass https://github.com/spacetelescope/RegressionTests/actions/runs/11365425316 so we're good with the changes

drlaw1558 commented 1 week ago

Updated to catch additional runtime warnings, and ensure the maximum amplitude is passed in the correct units so that it works for both FAST and SLOW mode data.