spacetelescope / stcal

https://stcal.readthedocs.io/en/latest/
Other
10 stars 32 forks source link

Pull common parts of skymatch from romancal and jwst into stcal #310

Open WilliamJamieson opened 2 weeks ago

WilliamJamieson commented 2 weeks ago

This PR pulls the common parts of skymatch from romancal and jwst into stcal to be shared.

Note, no tests are included because it is well tested by the step tests in both romancal and jwst.

Tasks

news fragment change types... - ``changes/.apichange.rst``: change to public API - ``changes/.bugfix.rst``: fixes an issue - ``changes/.general.rst``: infrastructure or miscellaneous change
codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 74.07407% with 329 lines in your changes missing coverage. Please review.

Project coverage is 84.71%. Comparing base (60bd3b8) to head (3f3832b). Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/stcal/skymatch/skyimage.py 61.09% 270 Missing :warning:
src/stcal/skymatch/region.py 85.13% 40 Missing :warning:
src/stcal/skymatch/skymatch.py 92.40% 19 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #310 +/- ## ========================================== - Coverage 86.21% 84.71% -1.51% ========================================== Files 47 54 +7 Lines 8812 10177 +1365 ========================================== + Hits 7597 8621 +1024 - Misses 1215 1556 +341 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.