Closed emolter closed 1 day ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 86.35%. Comparing base (
60bd3b8
) to head (22252ff
). Report is 6 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I'm pretty confident this will not change anything downstream, as the unit tests for the changed function appear to be relatively robust, but I started some downstream JWST regression tests here anyway
edit: these failures are unrelated
Resolves AL-875
This PR adds memory-saving options to a call to astropy
sigma clip
withincompute_weight_threshold
in an attempt to decrease the overall memory usage of outlier detection step (see flamegraphs on JP-3685), which cause that function to modify the input array in-place instead of copying it and allocating extra arrays for masks. Since the output sigma-clipped array is immediately collapsed into its mean, there is no need to retain it as a masked array and the behavior is unchanged.Note that the "masked=False" option to sigma_clip does not affect that function's processing of input masked arrays, it only specifies whether the output is a masked array with clipped pixels masked, or a simple np.array with clipped pixels removed.
Tasks
docs/
pageno-changelog-entry-needed
)changes/
:echo "changed something" > changes/<PR#>.<changetype>.rst
(see below for change types)"git+https://github.com/<fork>/stcal@<branch>"
)jwst
regression testromancal
regression testnews fragment change types...
- ``changes/