spacetelescope / stdatamodels

https://stdatamodels.readthedocs.io
Other
5 stars 25 forks source link

catch expected NoTypeWarnings in tests #172

Closed braingram closed 1 year ago

braingram commented 1 year ago

I noticed a few expected NoTypeWarning messages in the test logs. This PR uses pytest.warns to catch (and check for) these warnings and modifies the import of NoTypeWarning in test_schema_against_crds.py to make sure that the issued NoTypeWarning class in the warning filter matches the one issued by the code (this can differ if the tests are run from the repository by the code being tested is installed).

Checklist

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (43877cb) 63.69% compared to head (1cfff19) 63.69%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #172 +/- ## ======================================= Coverage 63.69% 63.69% ======================================= Files 100 100 Lines 5517 5517 ======================================= Hits 3514 3514 Misses 2003 2003 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

braingram commented 1 year ago

jwst downstream test failures are expected and unrelated. They are related to https://github.com/spacetelescope/jwst/pull/7590 and https://github.com/spacetelescope/jwst/pull/7605