search

spacetelescope / stdatamodels

https://stdatamodels.readthedocs.io
Other
5 stars 25 forks source link

use asdf instead of jsonschema directly #177

Closed braingram closed 1 year ago

braingram commented 1 year ago

get ValidationError from asdf.exceptions get 'type' validator from asdf.schema.YAML_VALIDATORS

Regression tests running at: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/790/

Checklist

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% :warning:

Comparison is base (d590345) 64.04% compared to head (87fb0c7) 64.04%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #177 +/- ## ========================================== - Coverage 64.04% 64.04% -0.01% ========================================== Files 101 101 Lines 5563 5562 -1 ========================================== - Hits 3563 3562 -1 Misses 2000 2000 ``` | [Files Changed](https://app.codecov.io/gh/spacetelescope/stdatamodels/pull/177?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spacetelescope) | Coverage Δ | | |---|---|---| | [src/stdatamodels/fits\_support.py](https://app.codecov.io/gh/spacetelescope/stdatamodels/pull/177?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spacetelescope#diff-c3JjL3N0ZGF0YW1vZGVscy9maXRzX3N1cHBvcnQucHk=) | `90.25% <100.00%> (-0.03%)` | :arrow_down: | | [src/stdatamodels/validate.py](https://app.codecov.io/gh/spacetelescope/stdatamodels/pull/177?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spacetelescope#diff-c3JjL3N0ZGF0YW1vZGVscy92YWxpZGF0ZS5weQ==) | `63.04% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

braingram commented 1 year ago

regtests showed 15 failures all similar to previous failures related to R_D/F/SFLAT keywords:

     Headers contain differences:
       Headers have different number of cards:
        a: 226
        b: 232
       Extra keyword 'R_DFLAT' in b: 'N/A'
       Extra keyword 'R_FFLAT' in b: 'N/A'
       Extra keyword 'R_SFLAT' in b: 'N/A'
       Inconsistent duplicates of keyword ''      :
        Occurs 41 time(s) in a, 44 times in (b)
braingram commented 1 year ago

Thanks for the review!