spacetelescope / stdatamodels

https://stdatamodels.readthedocs.io
Other
5 stars 25 forks source link

add weekly cron env to tox.ini to fix tox 4.9 compatibility #195

Closed braingram closed 1 year ago

braingram commented 1 year ago

See: https://github.com/spacetelescope/roman_datamodels/pull/261 for more details

tox 4.9 will no longer run environments that are not either:

This PR adds the weekly cron env test-devdeps-xdist to tox.ini so hopefully it will ~fail in a new way~ succeed next week when run with tox 4.9.

Checklist

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (345ae49) 64.01% compared to head (7281f5c) 64.01%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #195 +/- ## ======================================= Coverage 64.01% 64.01% ======================================= Files 101 101 Lines 5558 5558 ======================================= Hits 3558 3558 Misses 2000 2000 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

braingram commented 1 year ago

The test failures appear unrelated to the changes in this PR.

Something appears up with test_crds_selectors_vs_datamodel[miri] perhaps a CRDS file was updated?

braingram commented 1 year ago

test_crds_selectors_vs_datamodel[miri] failure (seen in several test runs) is unrelated and due to an update to a file on CRDS.

zacharyburnett commented 1 year ago

LGTM, when tests pass

braingram commented 1 year ago

LGTM, when tests pass

Thanks! All green after rebasing with changes from: https://github.com/spacetelescope/stdatamodels/pull/197