spacetelescope / stdatamodels

https://stdatamodels.readthedocs.io
Other
5 stars 25 forks source link

JP-3244: Add dither pointing RA/Dec to schema #203

Closed tapastro closed 1 year ago

tapastro commented 1 year ago

Resolves JP-3244

This PR addresses issues in extraction window centering for MIRI LRS fixed slit observations. Target RA/Dec information is not necessarily accurate, and an alternative was desired. The dither offset from slit center is a known and fixed quantity - we can use this with the transforms and wcsinfo metadata to store the RA/Dec of the dither offset position for extraction centering. It must be stored rather than calculated on the fly because the WCS frames necessary for calculation from existing metadata no longer exist after the product is resampled, prior to extraction.

Checklist

codecov[bot] commented 1 year ago

Codecov Report

Patch has no changes to coverable lines.

:loudspeaker: Thoughts on this report? Let us know!.

hbushouse commented 1 year ago

I know this is related to the work being done for JP-3244 to fix extraction aperture centering for NIRSpec FS and MOS, but there are also several existing tickets explicitly for these kinds of extraction problems in MIRI LRS, such as JP-2858 and JP-3021, so referencing those here too.

tapastro commented 1 year ago

The initial goal was to have them used for internal purposes only, but they weren't passed through resample_spec if not listed in the schema. I suppose they could be useful to users to see where (modulo a transform) the pipeline placed the extraction center for these exposures. The current PR implementation only populates these for MIRI_LRS-FIXEDSLIT. Apart from a difference in frame, they are not too dissimilar from source_xpos/ypos, but those keywords are defined for slit models, which MIRI LRS does not make use of.