remove redundant check in rebuild_fits_rec_dtype

spacetelescope / stdatamodels

https://stdatamodels.readthedocs.io

Other

5 stars 24 forks source link

remove redundant check in rebuild_fits_rec_dtype #207

Closed braingram closed 11 months ago

braingram commented 12 months ago

unsigned integers are unsupported by FITS and will be saved as signed integers with an offset (by astropy) so there is no need to check that the stored type is signed if the dtype presented to the user is unsigned.

Fixes #206

Checklist

[ ] added entry in CHANGES.rst (either in Bug Fixes or Changes to API)
[ ] updated relevant tests
[ ] updated relevant documentation
[ ] updated relevant milestone(s)
[ ] added relevant label(s)

codecov[bot] commented 12 months ago

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed	Coverage
src/stdatamodels/util.py	`100.00%`

:loudspeaker: Thoughts on this report? Let us know!.

braingram commented 11 months ago

The removed check does not appear to be redundant. See comments on #206