spacetelescope / stdatamodels

https://stdatamodels.readthedocs.io
Other
5 stars 24 forks source link

fix rebuild_fits_rec_dtype for shaped columns #213

Closed braingram closed 9 months ago

braingram commented 11 months ago

stdatamodels.util.rebuild_fits_rec_dtype appears to incorrectly handle unsigned integer columns with shapes. This PR updates rebuild_fits_rec_dtype and adds tests for this error.

Closes https://github.com/spacetelescope/stdatamodels/issues/206

Regression tests run with no errors: https://plwishmaster.stsci.edu:8081/blue/organizations/jenkins/RT%2FJWST-Developers-Pull-Requests/detail/JWST-Developers-Pull-Requests/963/pipeline

Checklist

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (0ed03c2) 64.68% compared to head (e8a83fd) 64.70%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #213 +/- ## ========================================== + Coverage 64.68% 64.70% +0.01% ========================================== Files 102 102 Lines 5663 5666 +3 ========================================== + Hits 3663 3666 +3 Misses 2000 2000 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.