search

spacetelescope / stdatamodels

https://stdatamodels.readthedocs.io
Other
5 stars 24 forks source link

TST: Python 3.12 #216

Closed pllim closed 5 months ago

pllim commented 11 months ago

Resolves JP-nnnn Resolves RCAL-nnnn

Closes #

This PR addresses ...

Checklist

codecov[bot] commented 11 months ago

Codecov Report

Patch has no changes to coverable lines.

:loudspeaker: Thoughts on this report? Let us know!.

pllim commented 11 months ago

Ah, sorry, I only opened this PR to see if this repo would even build in Python 3.12, not trying to fix anything here. Looks like it did.

Then I don't understand why Jdaviz is getting this error at https://github.com/spacetelescope/jdaviz/pull/2473 . Am I misreading the log? https://github.com/spacetelescope/jdaviz/actions/runs/6265287385/job/17013793326?pr=2473

Running command git clone --filter=blob:none --quiet https://github.com/spacetelescope/stdatamodels.git /tmp/pip-req-build-es2zgbyc
2023-09-21T18:04:04.7087103Z   error: subprocess-exited-with-error
2023-09-21T18:04:04.7087352Z   
2023-09-21T18:04:04.7087774Z   × Getting requirements to build wheel did not run successfully.
2023-09-21T18:04:04.7088139Z   │ exit code: 1
2023-09-21T18:04:04.7088433Z   ╰─> [33 lines of output]
2023-09-21T18:04:04.7088705Z       Traceback (most recent call last):
2023-09-21T18:04:04.7096085Z         File "/home/runner/work/jdaviz/jdaviz/.tox/py312-test-devdeps/lib/python3.12/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in <module>
2023-09-21T18:04:04.7096621Z           main()
2023-09-21T18:04:04.7097484Z         File "/home/runner/work/jdaviz/jdaviz/.tox/py312-test-devdeps/lib/python3.12/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 335, in main
2023-09-21T18:04:04.7098090Z           json_out['return_val'] = hook(**hook_input['kwargs'])
2023-09-21T18:04:04.7098423Z                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2023-09-21T18:04:04.7099192Z         File "/home/runner/work/jdaviz/jdaviz/.tox/py312-test-devdeps/lib/python3.12/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 112, in get_requires_for_build_wheel
2023-09-21T18:04:04.7099706Z           backend = _build_backend()
2023-09-21T18:04:04.7099965Z                     ^^^^^^^^^^^^^^^^
2023-09-21T18:04:04.7100670Z         File "/home/runner/work/jdaviz/jdaviz/.tox/py312-test-devdeps/lib/python3.12/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 77, in _build_backend
2023-09-21T18:04:04.7101147Z           obj = import_module(mod_path)
2023-09-21T18:04:04.7101410Z                 ^^^^^^^^^^^^^^^^^^^^^^^
2023-09-21T18:04:04.7101966Z         File "/opt/hostedtoolcache/Python/3.12.0-rc.3/x64/lib/python3.12/importlib/__init__.py", line 90, in import_module
2023-09-21T18:04:04.7102430Z           return _bootstrap._gcd_import(name[level:], package, level)
2023-09-21T18:04:04.7103016Z                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2023-09-21T18:04:04.7103389Z         File "<frozen importlib._bootstrap>", line 1381, in _gcd_import
2023-09-21T18:04:04.7103976Z         File "<frozen importlib._bootstrap>", line 1354, in _find_and_load
2023-09-21T18:04:04.7104441Z         File "<frozen importlib._bootstrap>", line 1304, in _find_and_load_unlocked
2023-09-21T18:04:04.7104927Z         File "<frozen importlib._bootstrap>", line 488, in _call_with_frames_removed
2023-09-21T18:04:04.7105365Z         File "<frozen importlib._bootstrap>", line 1381, in _gcd_import
2023-09-21T18:04:04.7105783Z         File "<frozen importlib._bootstrap>", line 1354, in _find_and_load
2023-09-21T18:04:04.7106224Z         File "<frozen importlib._bootstrap>", line 1325, in _find_and_load_unlocked
2023-09-21T18:04:04.7106660Z         File "<frozen importlib._bootstrap>", line 929, in _load_unlocked
2023-09-21T18:04:04.7107115Z         File "<frozen importlib._bootstrap_external>", line 994, in exec_module
2023-09-21T18:04:04.7107573Z         File "<frozen importlib._bootstrap>", line 488, in _call_with_frames_removed
2023-09-21T18:04:04.7108262Z         File "/tmp/pip-build-env-ffxp36bk/overlay/lib/python3.12/site-packages/setuptools/__init__.py", line 16, in <module>
2023-09-21T18:04:04.7108690Z           import setuptools.version
2023-09-21T18:04:04.7109272Z         File "/tmp/pip-build-env-ffxp36bk/overlay/lib/python3.12/site-packages/setuptools/version.py", line 1, in <module>
2023-09-21T18:04:04.7109683Z           import pkg_resources
2023-09-21T18:04:04.7110254Z         File "/tmp/pip-build-env-ffxp36bk/overlay/lib/python3.12/site-packages/pkg_resources/__init__.py", line 2191, in <module>
2023-09-21T18:04:04.7110726Z           register_finder(pkgutil.ImpImporter, find_on_path)
2023-09-21T18:04:04.7111044Z                           ^^^^^^^^^^^^^^^^^^^
2023-09-21T18:04:04.7111545Z       AttributeError: module 'pkgutil' has no attribute 'ImpImporter'. Did you mean: 'zipimporter'?
2023-09-21T18:04:04.7111916Z       [end of output]
braingram commented 5 months ago

Closing as 3.12 is part of the CI: https://github.com/spacetelescope/stdatamodels/actions/runs/8239495278/job/22532853330