Closed braingram closed 10 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Files | Coverage Δ | |
---|---|---|
src/stdatamodels/jwst/datamodels/amioi.py | 100.00% <100.00%> (+2.63%) |
:arrow_up: |
:loudspeaker: Thoughts on this report? Let us know!
I tested the changes and they fixed the ValidationWarning
I encountered when trying to use AmiOIModel.update
. Thanks Brett!
As reported by @rcooper295 using
AmiOIModel.update
results in aValidationError
. This is due to the mapping of JWST to OIFITS keywords only duringAmiOIModel.on_save
(which is not called duringupdate
).This PR updates
AmiOIModel
to map JWST to OIFITS keywords before callingvalidate
(which is called duringupdate
and also fixes an issue that without this PRAmiOIModel.validate
would also similarly fail).Unit tests were added to verify that
AmiOIModel.update
andAmiOIModel.validate
run successfully for an OIFITS compliant model.Regression tests run with no errors: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1047/
Checklist
CHANGES.rst
(either inBug Fixes
orChanges to API
)