search

spacetelescope / stdatamodels

https://stdatamodels.readthedocs.io
Other
5 stars 24 forks source link

JP-3449: Add TMEASURE keyword to core schema #248

Closed emolter closed 7 months ago

emolter commented 7 months ago

Resolves JP-3449

Closes [spacetelescope/jwst#8036]

This PR addresses adding TMEASURE to the JWST core schema.

Checklist

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (d3fce42) 64.84% compared to head (264bb2d) 64.84%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #248 +/- ## ======================================= Coverage 64.84% 64.84% ======================================= Files 103 103 Lines 5694 5694 ======================================= Hits 3692 3692 Misses 2002 2002 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

emolter commented 7 months ago

I am working on JP-3465 but it isn't ready yet; here's a link to the draft PR.

hbushouse commented 7 months ago

@braingram This keyword will be populated by SDP code during level-1b processing, just like all the other time-related keywords. There is an existing JSDP ticket to compute the value and populate it, and a JWSTKD ticket to add the definition to the official JWST keyword dictionary. So all bases are covered.

hbushouse commented 7 months ago

All the CI failures seem to be due to the same test "test_crds_selectors_vs_datamodel[miri]" and appear to be having a problem with model.meta.exposure.ngroups. No idea why this change would be causing that failure. I've checked the new lines in the core.schema.yaml lines closely and I don't see any syntax errors that would cause other failures in the schema.

tapastro commented 7 months ago

All the CI failures seem to be due to the same test "test_crds_selectors_vs_datamodel[miri]" and appear to be having a problem with model.meta.exposure.ngroups. No idea why this change would be causing that failure. I've checked the new lines in the core.schema.yaml lines closely and I don't see any syntax errors that would cause other failures in the schema.

This was caused by a CRDS update that didn't have a matching datamodel update, addressed in #249.