JP-3519: Add noutputs and bunit to readnoise and superbias schemas

spacetelescope / stdatamodels

https://stdatamodels.readthedocs.io

Other

5 stars 24 forks source link

JP-3519: Add noutputs and bunit to readnoise and superbias schemas #250

Closed tapastro closed 7 months ago

tapastro commented 7 months ago

Resolves JP-3519

Closes spacetelescope/jwst#8217

This PR addresses a request to add keyword schemas for noutputs and bunit to the readnoise and superbias schemas, due to CRDS selection criteria updates for these reference files.

Checklist

[x] added entry in CHANGES.rst (either in Bug Fixes or Changes to API)
[ ] updated relevant tests
[ ] updated relevant documentation
[x] updated relevant milestone(s)
[x] added relevant label(s)

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (8bbfe71) 64.84% compared to head (a91000a) 64.84%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #250 +/- ## ======================================= Coverage 64.84% 64.84% ======================================= Files 103 103 Lines 5694 5694 ======================================= Hits 3692 3692 Misses 2002 2002 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

braingram commented 7 months ago

I think the errors should be fixed by https://github.com/spacetelescope/stdatamodels/pull/249

Would you rebase this PR and fix the changes conflict?

Otherwise looks good to me!