JP-3520: Add ngroups to mask datamodel

spacetelescope / stdatamodels

https://stdatamodels.readthedocs.io

Other

5 stars 24 forks source link

JP-3520: Add ngroups to mask datamodel #251

Closed tapastro closed 7 months ago

tapastro commented 7 months ago

Resolves JP-3520

This PR addresses an issue found in tests for JP-3519 - recent updates to the CRDS selection criteria for MIRI MRS bad pixel masks caused test failures due to the lack of these updates being applied to the datamodel.

Checklist

[x] added entry in CHANGES.rst (either in Bug Fixes or Changes to API)
[ ] updated relevant tests
[ ] updated relevant documentation
[ ] updated relevant milestone(s)
[x] added relevant label(s)

braingram commented 7 months ago

Any objection to https://github.com/spacetelescope/stdatamodels/pull/249 (it adds a formatted string to the test to hopefully provide some breadcrumbs to lead us to the offending file/parkey)

tapastro commented 7 months ago

Any objection to #249 (it adds a formatted string to the test to hopefully provide some breadcrumbs to lead us to the offending file/parkey)

🤦 No idea how I missed that! I'll attach your PR to the JP ticket and close this one.