spacetelescope / stdatamodels

https://stdatamodels.readthedocs.io
Other
5 stars 24 forks source link

add schema and model for nrm reference file #253

Closed braingram closed 6 months ago

braingram commented 7 months ago

This PR adds support (a schema and model) for the new NIRISS nrm reference file: https://jwst-crds-test.stsci.edu/browse/jwst_niriss_nrm_0002.fits

Local tests were performed to confirm that this file loads and the nrm array is available at the nrm attribute:

>> import stdatamodels.jwst.datamodels as dm
>> m = dm.open('jwst_niriss_nrm_0002.fits')
>> assert isinstance(m, dm.NRMModel)
>> m.nrm
array([[0., 0., 0., ..., 0., 0., 0.],
       [0., 0., 0., ..., 0., 0., 0.],
       [0., 0., 0., ..., 0., 0., 0.],
       ...,
       [0., 0., 0., ..., 0., 0., 0.],
       [0., 0., 0., ..., 0., 0., 0.],
       [0., 0., 0., ..., 0., 0., 0.]], dtype='>f4')

The local testing is important as this file only exists on https://jwst-crds-test.stsci.edu/ and the CI uses the non-test public crds: https://jwst-crds.stsci.edu/

Checklist

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.87%. Comparing base (4d7c3a6) to head (591ae0d). Report is 1 commits behind head on main.

:exclamation: Current head 591ae0d differs from pull request most recent head 7092a23. Consider uploading reports for the commit 7092a23 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #253 +/- ## ========================================== + Coverage 64.84% 64.87% +0.03% ========================================== Files 103 104 +1 Lines 5694 5699 +5 ========================================== + Hits 3692 3697 +5 Misses 2002 2002 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.