JP-3522: added keyword NOD_PTS to core schema

spacetelescope / stdatamodels

https://stdatamodels.readthedocs.io

Other

5 stars 24 forks source link

JP-3522: added keyword NOD_PTS to core schema #262

Closed emolter closed 4 months ago

emolter commented 5 months ago

Resolves JP-3522

Closes spacetelescope/jwst#8243

This PR adds keyword NOD_PTS to the core schema to better support association rules for NIRSpec MOS obeservations.

Checklist

[ ] added entry in CHANGES.rst (either in Bug Fixes or Changes to API)
[ ] updated relevant tests
[ ] updated relevant documentation
[ ] updated relevant milestone(s)
[ ] added relevant label(s)

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e8a8f9e) 64.84% compared to head (ffb5893) 64.84%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #262 +/- ## ======================================= Coverage 64.84% 64.84% ======================================= Files 103 103 Lines 5694 5694 ======================================= Hits 3692 3692 Misses 2002 2002 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

hbushouse commented 5 months ago

Need to keep this on hold temporarily, as there's on-going discussion within the JWST Keyword Dictionary review board as to whether we really want to add this new keyword or reuse the existing "PRIDTPTS" keyword to store this info.

hbushouse commented 4 months ago

Closing this PR, because it's no longer needed. The JWST Keyword Dictionary review board has decided to use the existing keyword "PRIDTPTS" instead of adding "NOD_PTS" (see JWSTKD-555).