search

spacetelescope / stdatamodels

https://stdatamodels.readthedocs.io
Other
5 stars 24 forks source link

JP-3585: removed deprecated MIRIRampModel, DrizProductModel, and Mult… #290

Closed emolter closed 3 months ago

emolter commented 3 months ago

…iProductModel

Resolves JP-3585

This PR removes long-deprecated and unused datamodels.

Checklist

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.84%. Comparing base (4d7c3a6) to head (81939f5). Report is 23 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #290 +/- ## ======================================= Coverage 64.84% 64.84% ======================================= Files 103 102 -1 Lines 5694 5694 ======================================= Hits 3692 3692 Misses 2002 2002 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

braingram commented 3 months ago

It appears this overlaps with changes in: https://github.com/spacetelescope/stdatamodels/pull/171 The linked PR is draft until a 2.0.0 release is ready (as the removal of these models triggers a major version change). That PR was woefully out-of-date (I just rebased it).

emolter commented 3 months ago

It appears this overlaps with changes in: #171 The linked PR is draft until a 2.0.0 release is ready (as the removal of these models triggers a major version change). That PR was woefully out-of-date (I just rebased it).

Ok, good to know. I'm happy to withdraw this PR, assign the JIRA ticket to you, and link that ticket with #171. Does that sound like the right path forward?

braingram commented 3 months ago

That sounds good. I swear there is an existing jira ticket that I was notified of and commented on last week during the flurry of ticket updates. I am trying (and at the moment failing) to find the other ticket. If I find it I'll update the ticket(s).