add erfa to devdeps - Githubissues

spacetelescope / stdatamodels

https://stdatamodels.readthedocs.io

Other

5 stars 25 forks source link

add erfa to devdeps #297

Closed braingram closed 6 months ago

braingram commented 6 months ago

Our py3-devdeps-xdist job is failing due to astropy expecting a dev version of erfa https://github.com/spacetelescope/stdatamodels/actions/runs/8422253967/job/23061149990

This PR adds erfa to requirements-dev.txt which allows the job to pass.

Checklist

[ ] added entry in CHANGES.rst (either in Bug Fixes or Changes to API)
[ ] updated relevant tests
[ ] updated relevant documentation
[ ] updated relevant milestone(s)
[ ] added relevant label(s)

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.96%. Comparing base (4d7c3a6) to head (64bf952). Report is 23 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #297 +/- ## ========================================== + Coverage 64.84% 64.96% +0.12% ========================================== Files 103 104 +1 Lines 5694 5714 +20 ========================================== + Hits 3692 3712 +20 Misses 2002 2002 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

braingram commented 6 months ago

A new version of erfa was released with numpy 2.0 support. Closing this as erfa is not a direct dependency (so hopefully astropy can handle installing the compatible version).