spacetelescope / stdatamodels

https://stdatamodels.readthedocs.io
Other
5 stars 25 forks source link

JP-3581: add badpix_selfcal step to core schema #305

Closed emolter closed 3 months ago

emolter commented 3 months ago

Resolves JP-3581

Closes #8369

This PR adds a new header keyword to the cal_step in the core schema to reflect the addition of the new badpix_selfcal step in JWST.

Checklist

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 66.22%. Comparing base (4d7c3a6) to head (a8e8665). Report is 61 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #305 +/- ## ========================================== + Coverage 64.84% 66.22% +1.38% ========================================== Files 103 101 -2 Lines 5694 5403 -291 ========================================== - Hits 3692 3578 -114 + Misses 2002 1825 -177 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

braingram commented 3 months ago

Changes LGTM.

I suggest we leave this open until the keyword changes make this "official" (in case some unforeseen name change occurs). See: https://github.com/spacetelescope/jwst/pull/8500#discussion_r1639940884