JP-3588: Implement new reference file datamodel for PASTASOSS transformations

spacetelescope / stdatamodels

https://stdatamodels.readthedocs.io

Other

5 stars 25 forks source link

JP-3588: Implement new reference file datamodel for PASTASOSS transformations #320

Closed tapastro closed 2 months ago

tapastro commented 3 months ago

Partially resolves JP-3588

This PR adds a new reference file datamodel for the PASTASOSS algorithm, replacing the existing ATOCA transformation algorithm. This effectively deprecates the spectrace and wavemap datamodels - TBD on how best to remove them from here and/or CRDS.

Checklist

[ ] added entry in CHANGES.rst (either in Bug Fixes or Changes to API)
[ ] updated relevant tests
[ ] updated relevant documentation
[ ] updated relevant milestone(s)
[ ] added relevant label(s)

braingram commented 3 months ago

🍝

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 66.44%. Comparing base (8a63a5f) to head (f78fb11). Report is 12 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #320 +/- ## ========================================== + Coverage 66.41% 66.44% +0.03% ========================================== Files 101 102 +1 Lines 5434 5439 +5 ========================================== + Hits 3609 3614 +5 Misses 1825 1825 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

braingram commented 3 months ago

The suggestions I added don't yet account for the ndim validators. I assume these properties are arrays? If so, the schema will have to be updated to accommodate that.

Would you add a unit test that makes an instance of the new model with expected junk data? That would help me understand what should go in those spots.