Closed tapastro closed 1 month ago
I'm running a set of regression tests for completeness: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1751/
But this made it through without a regression test failure, which would mean that we don't have a regression test that loads an uncal file with moving target data. This needs to be fixed in a yet-unwritten PR to
jwst
with a new test.
EDIT: I remember now - bad management advice from yours truly. @emolter modified the test's input file to include the new columns, which of course fixed the test but ignores the problems introduced for all other files. We can get coverage of this workaround by updating the test_nircam_mtimage to use flight data, as all uncals are still missing these columns (unless handcrafted...)
@emolter modified the test's input file to include the new columns, which of course fixed the test but ignores the problems introduced for all other files.
Guess I learned the hard way that this is bad practice... sorry about that. Should have thought it through more
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 66.55%. Comparing base (
1996b18
) to head (fd6be8d
). Report is 7 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
JWST regtests pass with this PR: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1755/
Merging!
Resolves JP-2349
This PR addresses validation issues encountered when opening
jwst
uncal files generated with DMS Ops builds <11.1 and usingstdatamodels
>=2.1.0. This most recent release ofstdatamodels
changed the number of columns in themoving_target_table
schema, which leads to validation errors when opening any existing file with an old moving target extension. For any users attempting to load an outdated uncal file, this PR will check for the missing columns and add nan-filled columns if they are missing.Tasks
docs/
pageno-changelog-entry-needed
)changes/
:echo "changed something" > changes/<PR#>.<changetype>.rst
(see below for change types)jwst
regression tests with this branch installed ("git+https://github.com/<fork>/stdatamodels@<branch>"
)news fragment change types...
- ``changes/