Closed braingram closed 3 weeks ago
Attention: Patch coverage is 97.57174%
with 11 lines
in your changes missing coverage. Please review.
Project coverage is 68.93%. Comparing base (
fd6be8d
) to head (616a09b
). Report is 8 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Based on discussion with @tapastro there are a few remaining issues to sort out with this PR prior to approval (based on discussion of the currently generated report).
@tapastro I think this is ready for final review. See the comment above https://github.com/spacetelescope/stdatamodels/pull/337#issuecomment-2445312775 for a checklist and linked commits for the items we discussed.
I also added a test that fetches the latest "published" keyword dictionary from MAST (using an "unofficial" service since there is no official one) and parses it generating a report as a test of the new tool. I think this is worth expanding by adding a CI job that:
This way we will know when PRs impact keyword dictionary differences (relative the published version, not the latest dev version which is not public). However it makes sense to me to split this work into a separate PR as I'd like to get this one in to also start working on PRs to address the many differences.
https://jira.stsci.edu/browse/JP-3783
As it currently stands this PR:
stdatamodels.jwst._kwtool
python -m stdatamodels.jwst._kwtool <keyword dictionary path>
Link to added docs: https://stdatamodels--337.org.readthedocs.build/en/337/jwst/kwtool/index.html
It would be helpful to have feedback on:
Some known issues are:
meta.items
). At first glance I would say this is a bug as I don't see how having every item in the list overwrite the PRIMARY EXP_TYPE is useful. However this might be a "bug" in the comparison where we don't care about this difference and we'll want some way to ignore it or not flag it as an issue in the first place. @tapastro does this usage look like a schema bug? If so I can open a separate issue.Tasks
docs/
pageno-changelog-entry-needed
)changes/
:echo "changed something" > changes/<PR#>.<changetype>.rst
(see below for change types)jwst
regression tests with this branch installed ("git+https://github.com/<fork>/stdatamodels@<branch>"
)news fragment change types...
- ``changes/