spacetelescope / stdatamodels

https://stdatamodels.readthedocs.io
Other
5 stars 25 forks source link

JP-3797: Add new subarray names for updated WFS&C apertures #358

Closed tapastro closed 2 weeks ago

tapastro commented 2 weeks ago

Resolves JP-3797

Closes jwst #8944

This PR adds new subarray names to the subarray enums to support WFS&C updates.

Tasks

news fragment change types... - ``changes/.feature.rst``: new feature - ``changes/.bugfix.rst``: fixes an issue - ``changes/.doc.rst``: documentation change - ``changes/.removal.rst``: deprecation or removal of public API - ``changes/.misc.rst``: infrastructure or miscellaneous change
tapastro commented 2 weeks ago

Sorry, missed the keyword schema! I think this is all of the necessary changes.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.51%. Comparing base (fd6be8d) to head (73c887c). Report is 13 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #358 +/- ## ========================================== + Coverage 66.55% 67.51% +0.96% ========================================== Files 102 114 +12 Lines 5456 5913 +457 ========================================== + Hits 3631 3992 +361 - Misses 1825 1921 +96 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

zacharyburnett commented 2 weeks ago

alright, so as soon as this is merged, I'll start making a release 2.1.2 based on release/2.1.x with this commit cherry-picked