search

spacetelescope / stdatamodels

https://stdatamodels.readthedocs.io
Other
5 stars 25 forks source link

Consider adding keyword dictionary "title" vs datamodel schema property "title" comparison #365

Open braingram opened 5 days ago

braingram commented 5 days ago

Uncal files contain fits headers formatted based on the keyword dictionary including "sections":


        Observation identifiers

DATE-OBS= '2020-06-05'         / [yyyy-mm-dd] UTC date at start of exposure

which I believe come from top file property titles like the following:

                "observation" : {
                    "title" : "Observation identifiers",

(aside: It's unclear at the moment how these relate to "Section" in the keyword definition)

"cal" files have similar sections


        Observation identifiers

DATE-OBS= '2019-10-15'         / [yyyy-mm-dd] UTC date at start of exposure

However these are derived from the datamodel schemas: https://github.com/spacetelescope/stdatamodels/blob/2c3985336e54fb4989460b08a94777dfb33640b7/src/stdatamodels/fits_support.py#L230-L233 Using the "title" keyword in the schemas: https://github.com/spacetelescope/stdatamodels/blob/2c3985336e54fb4989460b08a94777dfb33640b7/src/stdatamodels/jwst/datamodels/schemas/core.schema.yaml#L156-L157

If we want these to agree we would benefit from having the kwtool compare these for differences.