search

spacetelescope / stpipe

https://stpipe.readthedocs.io
Other
3 stars 25 forks source link

enable nolegacypath tox factor #146

Closed braingram closed 8 months ago

braingram commented 8 months ago

Fixes: https://github.com/spacetelescope/stpipe/issues/145

Add a nolegacypath tox factor that run pytest with -p no:legacypath which will produce errors if legacy "non-path" fixtures/features are used.

A tox factor was added to allow the downstream jobs (like romancal and jwst) to run without -p no:legacypath as we are mainly concerned here that stpipe does not use legacy path features in it's test suite (not the test suites of romancal and jwst).

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 59.25%. Comparing base (f9411a9) to head (44c1250). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #146 +/- ## ======================================= Coverage 59.25% 59.25% ======================================= Files 24 24 Lines 1615 1615 ======================================= Hits 957 957 Misses 658 658 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

braingram commented 8 months ago

Thanks @jdavies-st for the review. I just requested @nden for a review to hopefully appease the branch protection (I'm assuming @jdavies-st is not listed as an approved reviewer?).